Google Git
Sign in
chromium / infra / luci / luci-go / 2c12a01a4242884aaece20b93529b8ca69df1099
commit2c12a01a4242884aaece20b93529b8ca69df1099[log] [tgz]
authorYuanjun Huang <yuanjunh@google.com>Thu Jan 11 18:00:41 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 11 18:00:41 2024
treef3598db9577dc3d86a09931d39a3c6308d747836
parent28de46eed783b8518d6bcb8e30a488fe62a59632 [diff]
[buildbucket] CreateBackendTask: check if described cipd file has err

Fix the the nil pointer error in `extractCipdDetails`[1]. It's because
the described cipd pkd has an error on one of the platforms and it's
`file.instance` doesn't exist[2].

[1]: https://screenshot.googleplex.com/C9AtR2yjhg4QTyb
[2]: https://screenshot.googleplex.com/Bfvr6G5VMv42BPd

Bug:b/288158829
Change-Id: I4150959064978e0ced782412909a8cc981c85680
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5187822
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
2 files changed
tree: f3598db9577dc3d86a09931d39a3c6308d747836
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. third_party/
  40. tokenserver/
  41. tools/
  42. tree_status/
  43. vpython/
  44. web/
  45. .gitallowed
  46. .gitattributes
  47. .gitignore
  48. .go-lintable
  49. AUTHORS
  50. codereview.settings
  51. CONTRIBUTING.md
  52. CONTRIBUTORS
  53. go.mod
  54. go.sum
  55. LICENSE
  56. OWNERS
  57. PRESUBMIT.py
  58. README.md
  59. tools.go
  60. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.