Google Git
Sign in
chromium / infra / luci / luci-go / 34a4e50afb5cd29d09354b46f46f303412213370
commit34a4e50afb5cd29d09354b46f46f303412213370[log] [tgz]
authorPiotr Grabski-Gradziński <piotrgg@google.com>Mon May 26 11:46:46 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 26 11:46:46 2025
tree97587c02b352cd5ad3eb1727ffbf984da9757017
parent2d5c23bc0c997ca4f6de8b20c1f10b0e25bbe817 [diff]
Adding check for missing data in dimensionsQuery.

In local storage REACT_QUERY_OFFLINE_CACHE can contain empty data object which causes app to crash.

Demo: https://18307-2d5c23b-tainted-piotrgg-420287987-crash-dot-luci-milo-dev.appspot.com/ui/fleet/labs/devices

Bug: b/420287987
Change-Id: I4a1c59a70a4dfb198ca48378e52aa3ae98d904b6
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6586888
Reviewed-by: Konrad Polarczyk <polarczyk@google.com>
Commit-Queue: Piotr Grabski-Gradziński <piotrgg@google.com>
1 file changed
tree: 97587c02b352cd5ad3eb1727ffbf984da9757017
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. lucichecker.py
  59. OWNERS
  60. PRESUBMIT.py
  61. README.md
  62. staticcheck.conf
  63. tools.go
  64. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.