Google Git
Sign in
chromium / infra / luci / luci-go / 4e541a0da42101abeac97a84eda0c4f3d29ae575
commit4e541a0da42101abeac97a84eda0c4f3d29ae575[log] [tgz]
authorAravind Vasudevan <aravindvasudev@google.com>Tue Nov 07 00:57:20 2023
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 07 00:57:20 2023
treecc5b773b83f3586ba945d17076e04be50e327961
parent14226e183e27359ca0842615ef81cdf6d0bdbf67 [diff]
[cv] Fix pending_msg to be posted only once

The current implementation for posting pending msg when quota is not
available has two issues:
1. Gerrit prepends metadata to the posted msg which breaks
   post_gerrit_messsage's deduplication logic of using equality check.
2. Longops are executed before start handler in run manager which
   removes the pending msg entry from run.OngoingLongOps before start
   handler is executed, leading to start handler making duplicate
   enqueues.

This CL fixes both of the aforementioned issues by updating equality check to contains check within post_gerrit_messsage and adding a new PendingMsgPosted entry to runState which restricts enqueuing pending msg to only once.

The downside of this change is that, if posting pending msg longop fails, we do not re-enqueue another longop. However, this should be an
edge case given we retry posting the longop anyway.

Bug: 1466346
Change-Id: I55d800346b5369184cd161959b0d0cf029e701d3
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5007182
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
5 files changed
tree: cc5b773b83f3586ba945d17076e04be50e327961
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. third_party/
  40. tokenserver/
  41. tools/
  42. tree_status/
  43. vpython/
  44. web/
  45. .gitallowed
  46. .gitattributes
  47. .gitignore
  48. .golangci.yml
  49. AUTHORS
  50. codereview.settings
  51. CONTRIBUTING.md
  52. CONTRIBUTORS
  53. go.mod
  54. go.sum
  55. LICENSE
  56. OWNERS
  57. PRESUBMIT.py
  58. README.md
  59. tools.go
  60. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.