Google Git
Sign in
chromium / infra / luci / luci-go / 57e26024005fb3c93f58c7161f5eb26aadc279ec
commit57e26024005fb3c93f58c7161f5eb26aadc279ec[log] [tgz]
authorOliver Newman <olivernewman@google.com>Wed Feb 02 00:18:18 2022
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 02 00:18:18 2022
tree920455b2508d029d82a5633c5b2be2e30cdf7233
parent58b22ec79adbb1453fc86b4295d7f6a1bc57b1bf [diff]
[led] Propagate error if `python` is not in $PATH

This causes a prepBundle() to return an exec.ErrNotFound, which would be
silently ignored due to not propagating the error. I actually introduced
this bug myself in https://crrev.com/c/3035428.

Also update cmdErr() to handle errors besides exec.ExitError - other
errors would previously not be included in the error message, making
them very hard to debug.

Change-Id: I40c7b53d7e5f90249510c1d5bbaf0577cdac235a
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3429541
Auto-Submit: Oliver Newman <olivernewman@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
1 file changed
tree: 920455b2508d029d82a5633c5b2be2e30cdf7233
  1. appengine/
  2. auth/
  3. auth_service/
  4. build/
  5. buildbucket/
  6. casviewer/
  7. cipd/
  8. client/
  9. cmdrunner/
  10. common/
  11. config/
  12. cv/
  13. dm/
  14. examples/
  15. gae/
  16. gce/
  17. grpc/
  18. hacks/
  19. hardcoded/
  20. led/
  21. logdog/
  22. luci_notify/
  23. lucicfg/
  24. lucictx/
  25. luciexe/
  26. machine-db/
  27. mailer/
  28. milo/
  29. mmutex/
  30. resultdb/
  31. scheduler/
  32. scripts/
  33. server/
  34. starlark/
  35. swarming/
  36. tokenserver/
  37. tools/
  38. tumble/
  39. vpython/
  40. web/
  41. .gitallowed
  42. .gitattributes
  43. .golangci.yml
  44. AUTHORS
  45. codereview.settings
  46. CONTRIBUTING.md
  47. CONTRIBUTORS
  48. go.mod
  49. go.sum
  50. LICENSE
  51. OWNERS
  52. PRESUBMIT.py
  53. README.md
  54. tools.go
  55. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

Contributing

Contributing uses the same flow as Chromium contributions.