Google Git
Sign in
chromium / infra / luci / luci-go / 585f686d830c8832820bf8f326088ae2df5cce44
commit585f686d830c8832820bf8f326088ae2df5cce44[log] [tgz]
authorAnne Redulla <aredulla@google.com>Tue Nov 28 21:29:49 2023
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 28 21:29:49 2023
tree933b4d18542d77c89b0152f3a14d611ea55396ad
parentf503b19f0ebf536949dcb9a8a43d71b7210d35ae [diff]
Reland "[auth-service] Check permissions changes before committing"

This is a reland of commit 22fa19cdd3f91377acc8ab4cf00e582504a3f34c

Original change's description:
> [auth-service] Check permissions changes before committing
>
> Instead of adding a new function CheckPermissionsChanges,
> this CL adds a check before calling commitEntity in
> UpdateAuthRealmsGlobals.
>
> It also updates the cron.yaml to use the same names as registered in
> services/backend/main.go.
>
> Bug: b:312072310
> Change-Id: Icf71da05e2480e320adab3d569088190cafeab50
> Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5047557
> Reviewed-by: Camilo Jacomet <cjacomet@google.com>
> Commit-Queue: Anne Redulla <aredulla@google.com>

Bug: b:312072310
Change-Id: Ib40279daa53e8eb1ecf4a836e6fcf80e0e59e944
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5064809
Auto-Submit: Anne Redulla <aredulla@google.com>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
Reviewed-by: Camilo Jacomet <cjacomet@google.com>
4 files changed
tree: 933b4d18542d77c89b0152f3a14d611ea55396ad
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. third_party/
  40. tokenserver/
  41. tools/
  42. tree_status/
  43. vpython/
  44. web/
  45. .gitallowed
  46. .gitattributes
  47. .gitignore
  48. .golangci.yml
  49. AUTHORS
  50. codereview.settings
  51. CONTRIBUTING.md
  52. CONTRIBUTORS
  53. go.mod
  54. go.sum
  55. LICENSE
  56. OWNERS
  57. PRESUBMIT.py
  58. README.md
  59. tools.go
  60. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.