commit | 63d84c859933df4a8033ff95104346f41850e132 | [log] [tgz] |
---|---|---|
author | Yiwei Zhang <yiwzhang@google.com> | Mon Aug 05 22:12:24 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Aug 05 22:12:24 2024 |
tree | 6bda4eb957c55e4e6b276253c2588a7e08e68acc | |
parent | 5793f9b597163f1af32f92b54093ee3fe7e4a4ff [diff] |
cv: remove dependency to goconvey in cvtesting/utils as we are moving away from goconvey (See: go/noconvey-migration), LUCI CV testing utils should not assume the tests are running in goconvey context. Therefore, the `So` statement should be replaced by the new assertion library which would directly fail the test. The change also uses the cleanup from go testing lib instead of reinventing the wheel. R=ddoman Change-Id: I1437b3337a03ef0922af8cb81ed3125f28f7e853 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5762782 Auto-Submit: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Scott Lee <ddoman@chromium.org> Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.