| commit | f9b914e154c1943d84c40177bf346dc978819cfa | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Wed May 22 01:16:59 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed May 22 01:16:59 2019 |
| tree | 372198989e0617413d5c3f5eb0d319e31bbb03e5 | |
| parent | a3900af1a909952be27e53bd91f3e7bc474ab506 [diff] |
[portal] Skip auth when admin endpoints are exposed on an internal port. Will be used in k8s environment, at least initially. This approach assumes we don't expose any really critical information/abilities via /admin/portal pages. If we ever do, we should figure out a better authentication story (perhaps piggy back on k8s auth somehow). Few hours of research didn't find anything easily implementable. R=jchinlee@chromium.org, nodir@chromium.org, tandrii@chromium.org BUG=959427 Change-Id: I99d5cd73786e86bd093ccf5d74d8d7c56e1c3e07 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1621749 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.