commit | 6b9efebbb47da592667302f50626824da659ece1 | [log] [tgz] |
---|---|---|
author | Beining Chen <beining@google.com> | Wed Apr 03 22:45:03 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 03 22:45:03 2024 |
tree | b80ad3187ab11adccccd34b146547c0532ad3cd8 | |
parent | f348a6a1b232852762553ff42a8266409987d0a7 [diff] |
[Notify] Not throw when gitile fail in pubsub This CL is to silence an error from luci-notify b/327194539#9. A previous CL[1], checks the status code in luci notify. But Gitile call is using REST, code.Unknown is attach for all REST call errors. Let's attach the code.DeadlineExceeded for context.DeadlineExceeded error. [1]https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5382005 bug: b/327194539 Change-Id: Ic0dbafc911f6cb8d174e689da7c0892a8f84a81a Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5403727 Reviewed-by: Patrick Meiring <meiring@google.com> Commit-Queue: Beining Chen <beining@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.