| commit | 76720aa038c2470176c0d58a4eac44de6cda76a8 | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Tue Mar 19 19:46:00 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 19 19:46:00 2019 |
| tree | 9b2a4027f25912011f73835a3b566a35b3ae5379 | |
| parent | 3bd14eff34b1531db6f7fde086ef0c52a17fb2b3 [diff] |
[lucicfg] Make graph.add_edge idempotent.
Edge redeclaration errors were never useful (never seen it in the real
situations), but they complicate working with "idempotent" nodes (nodes that
are allowed to be added more than once without triggering a redeclaration
error).
In practical terms it means e.g. the following config is no longer erroneous:
luci.gitiles_poller(
...
triggers = [
'some builder',
'some builder', # duplicates are silently ignored
...
],
)
R=tandrii@chromium.org, nodir@chromium.org
BUG=833946
Change-Id: Ie102a487e4482555b59dfc5260bfda65c79125d6
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1526716
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.