commit 980485327acf7d09b8f21f64154466cf06e8d9ce
author Robert Iannucci <iannucci@chromium.org> Wed May 08 21:19:51 2024
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed May 08 21:19:51 2024
tree be085b01483800133b0adcd9b0007d4ab81040e8
parent 2311e6347449be2e313bde956d22e56b0bc12984

[testing] Make spellings of all symbols flow better.

Previously you could either import the `assert` package with dot
imports to get Assert/Check (and their cryptic "L" variants)... but
dot importing is not great.

Or you could not dot import and then you had `assert.Assert` (ew) or
`assert.Check` (what?).

This package renames `assert` to `truth`, and renames the "L"
variants to the more verbose "Loosely". This gives the names
`truth.Assert` and `truth.CheckLoosely`, which are better. In
addition, this also makes a new `assert` and `check` package, which
each export `That` and `Loosely` symbols. This results in fairly
natural spellings like:

   check.Loosely(t, myCustomInt(10), should.Equal(10))
   assert.That(t, "something", should.HavePrefix("some"))

Which I believe are concise and clear, and don't require polluting
the global namespace with any dot imports.

This additionally removes the custom `testing.TB` subset interface,
which was only done to avoid importing "testing". Removing it just
results in one fewer weird thing to remember.

R=gregorynisbet@google.com

Bug: 319730573
Change-Id: Ibc237811e70ed1cf2dfcf8fb999ea51c63f42acf
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5527814
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Gregory Nisbet <gregorynisbet@google.com>