Google Git
Sign in
chromium / infra / luci / luci-go / 9c721ab269f1f101c366443cee634f25fbdfe390
commit9c721ab269f1f101c366443cee634f25fbdfe390[log] [tgz]
authorPatrick Meiring <meiring@google.com>Tue Apr 29 04:22:19 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 29 04:22:19 2025
tree896e445b9253e801dad418e963ed4c097e12ed7a
parent569d0e9f53aa6ab38c58c22f65276e9478f93e69 [diff]
[ResultDB] Normalise failure reason storage around Errors collection.

The Errors collection should be the source of truth for the
failure reason's errors, with primary_error_message becoming
a computed field. Of the two, only the errors collection should be
stored in Spanner.

At upload time, we convert the primary_error_message into
a single-entry errors collection if errors is unset, to support
handling legacy clients.

This CL is best read in context of the validation CL, in partcular
the new ValidateFailureReason method:
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6450325

BUG=b:410660296

Change-Id: I3746e48f8708e9af76785cabd82f75d970b2b464
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6477726
Reviewed-by: Beining Chen <beining@google.com>
Commit-Queue: Patrick Meiring <meiring@google.com>
12 files changed
tree: 896e445b9253e801dad418e963ed4c097e12ed7a
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. OWNERS
  59. PRESUBMIT.py
  60. README.md
  61. staticcheck.conf
  62. tools.go
  63. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.