commit b6843aeee2d446d09ff387cef03915eedc6aa08e
author Robert Iannucci <iannucci@chromium.org> Wed Oct 02 23:49:38 2024
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 02 23:49:38 2024
tree abb9422bd1225922b4ca00f8a6241e0fb9dc38a0
parent 53258e31bf80772ba4de77f3b568804d71d166f4

[ftt/rewriter] When rewriting an incompatible convey suite, always pivot context.

This prevents code like:

  Convey(`something`, t, <valid Go but not a func()> {
    Convey(`else`, func() { ... })  // matches!
  })

From being converted into (and then not being rendered to the output
file at all, because it's syntactically invalid and format.Node
fails):

  Convey(`something`, t, <valid Go but not a func()> {
    .Run(`else`, func() { ... })
  })

But instead into the syntactically valid (but non-compiling):

  Convey(`something`, t, <valid Go but not a func()> {
    t.Run(`else`, func() { ... })
  })

Which is easy to fix by hand.

R=gregorynisbet

Change-Id: I265a0a659e444d918016254894e6d9a0191fd14d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5901865
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Bryan Ni <bniche@google.com>
Commit-Queue: Bryan Ni <bniche@google.com>