| commit | b837abc3156fccbd8f380c39a5232857efa0af89 | [log] [tgz] |
|---|---|---|
| author | Gregory Nisbet <gregorynisbet@google.com> | Fri Oct 14 20:49:21 2022 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 14 20:49:21 2022 |
| tree | 4eac03e4bb6604c7029c7941c29d26b7403e6066 | |
| parent | 788146f9c61764e1e6cce3412444a5319e9ff959 [diff] |
Revert "[buildbucket] Splitting BuildOutputProperties into multiple entities" This reverts commit 50878307ff6f4ae39b0221b7995ab6cce2fbce12. Reason for revert: tree closed https://cr-buildbucket.appspot.com/build/8800297975075647393 Original change's description: > [buildbucket] Splitting BuildOutputProperties into multiple entities > > Add a new `PropertyChunk` Datastore model and also add a new field > `ChunkCount` in `BuildOutputProperties` to record the number of entities it splits into. Still keep the original `BuildOutputProperties.Proto` field to store the proto and only split it when the size is larger than 1000*1000. > > Python side dependencies: > 1. v1 flows - have both read and write to it. Should be fine. The current structure change is compatible as v1 builds aren’t large. > > 2. In v2 flows, only "builds" pubsub needs to reads output_properties. If we don’t change Py code, the large properties will be omitted while the normal properties can still be retrieved. Audited the usage. Among 10+ subscribers, only `nest-spt2` needs output_properties info and they don’t have large builds. Should be fine as well. > > Bug: 1336469 > Change-Id: I9f2287d385943500ab7c699e30791f76d9ee15f1 > Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3931079 > Reviewed-by: Chan Li <chanli@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Yuanjun Huang <yuanjunh@google.com> Bug: 1336469 Change-Id: Id23fce47abe0176e8a13842913da7b307812eed4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/3957735 Auto-Submit: Gregory Nisbet <gregorynisbet@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Gregory Nisbet <gregorynisbet@google.com> Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.