commit | c9cce4d1736bbb7f8943930c72d6feaa5d25f7d7 | [log] [tgz] |
---|---|---|
author | Weiwei Lin <weiweilin@google.com> | Mon Jan 29 23:40:00 2024 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jan 29 23:40:00 2024 |
tree | c1cf1c3c214e6ac70945bb5c33b6dbec4e357217 | |
parent | 7bb9a2b183ab4d6f6ca86843da66b8694a3d9b4a [diff] |
analysis: attribute skipped tests to failures in any milestone Ideally, the skipped test results should be attributed to failures that caused them. i.e. failures in the same milestone if there are enough samples, or failures in the previous milestone if there are not enough samples. But given that luci-analysis does not know whether the testing filtering was activated from failures from the current milestone or the previous milestone, it's hard to write a query that can attribute correctly. Instead, we attribute skipped test results to failures in the any milestone. This is only an issue when 1. the test is failing in a previous milestone for a different root cause, and 2. the failures in the other milestone did not trigger test filtering themselves (therefore already marked as "triggered test filtering"). Hopefully, this should be very rare. And we can adjust the attribution logic further if this become an issue. R=meiring@google.com, mwarton@google.com Bug: b/312590738 Change-Id: Ifbd6e99b8af787fe328d44bb240620f091dc2c7d Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5208370 Reviewed-by: Matthew Warton <mwarton@google.com> Commit-Queue: Weiwei Lin <weiweilin@google.com>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
It is now possible to directly install tools with go install:
go install go.chromium.org/luci/auth/client/cmd/...@latest go install go.chromium.org/luci/buildbucket/cmd/...@latest go install go.chromium.org/luci/cipd/client/cmd/...@latest go install go.chromium.org/luci/client/cmd/...@latest go install go.chromium.org/luci/cv/cmd/...@latest go install go.chromium.org/luci/gce/cmd/...@latest go install go.chromium.org/luci/grpc/cmd/...@latest go install go.chromium.org/luci/logdog/client/cmd/...@latest go install go.chromium.org/luci/luci_notify/cmd/...@latest go install go.chromium.org/luci/lucicfg/cmd/...@latest go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest go install go.chromium.org/luci/mailer/cmd/...@latest go install go.chromium.org/luci/mmutex/cmd/...@latest go install go.chromium.org/luci/resultdb/cmd/...@latest go install go.chromium.org/luci/server/cmd/...@latest go install go.chromium.org/luci/swarming/cmd/...@latest go install go.chromium.org/luci/tokenserver/cmd/...@latest go install go.chromium.org/luci/tools/cmd/...@latest
Contributing uses the same flow as Chromium contributions.