Google Git
Sign in
chromium / infra / luci / luci-go / edafe86a5717887b96bb1dd4e79d484b91140549
commitedafe86a5717887b96bb1dd4e79d484b91140549[log] [tgz]
authorVadim Shtayura <vadimsh@chromium.org>Tue May 07 17:10:09 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 07 17:10:09 2024
treec4ed707ba86dde24b4c33957d742f960cc743585
parent674f2681ba73e5a62bdf5ae22623992dd95e7e1a [diff]
[swarming] Ignore STREAM_ALREADY_COMMITTED error.

It appears (based on logs on chrome-swarming) that GetWriteStream
is "eventually consistent", i.e. it may indicate the stream is
pending even after BatchCommitWriteStreams has successfully
finished (even if all calls happen serially, no race conditions).

When this happens and we try to commit the stream, we get back
STREAM_ALREADY_COMMITTED error, which marks the TQ task as
fatally failed (which is technically fine, but noisy).

Ignore this error. It indicates the retry wasn't needed and
everything is OK already.

R=chanli@chromium.org

Change-Id: I5e147d9b287dbfcccfa88340c70de114b832c584
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5520046
Reviewed-by: JB Tamas-Leloup <jtamasleloup@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
1 file changed
tree: c4ed707ba86dde24b4c33957d742f960cc743585
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. resultdb/
  33. scheduler/
  34. scripts/
  35. server/
  36. standalone/
  37. starlark/
  38. swarming/
  39. teams/
  40. third_party/
  41. tokenserver/
  42. tools/
  43. tree_status/
  44. vpython/
  45. web/
  46. .gitallowed
  47. .gitattributes
  48. .gitignore
  49. .go-lintable
  50. AUTHORS
  51. codereview.settings
  52. CONTRIBUTING.md
  53. CONTRIBUTORS
  54. go.mod
  55. go.sum
  56. LICENSE
  57. OWNERS
  58. PRESUBMIT.py
  59. README.md
  60. tools.go
  61. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.