Google Git
Sign in
chromium / infra / luci / luci-go / f721a4ee137dd28b68a6188b266d7ff23ebe50f3
commitf721a4ee137dd28b68a6188b266d7ff23ebe50f3[log] [tgz]
authorAndrii Shyshkalov <tandrii@chromium.org>Fri Apr 05 21:02:17 2019
committerCommit Bot <commit-bot@chromium.org>Fri Apr 05 21:02:17 2019
treefb332e7442e31528312af0350ee8db94b4a06933
parent41a9ed27b3f0391586c27ce5d490eed3522b63e5 [diff]
luci_notify: disallow luci.<project_name> from short bucket names.

Strictly speaking, backwards incompatible change, projects can no
longer watch buckets named (short name) "luci.foo.bar"
(ie full legacy bucket name luci.<project>.luci.foo.bar).
However, as of now it's not actually used AND
it's a common mistake wasting hours of uses and maintainers.

Also fixes incorrect tests.

R=nodir

Change-Id: I1f466f01ef3d870a3dd5d00f1390b2a2941a37d2
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/1555253
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
2 files changed
tree: fb332e7442e31528312af0350ee8db94b4a06933
  1. appengine/
  2. auth/
  3. buildbucket/
  4. cipd/
  5. client/
  6. common/
  7. config/
  8. cq/
  9. dm/
  10. examples/
  11. gce/
  12. grpc/
  13. hardcoded/
  14. logdog/
  15. luci_notify/
  16. lucicfg/
  17. lucictx/
  18. machine-db/
  19. milo/
  20. mmutex/
  21. mp/
  22. scheduler/
  23. scripts/
  24. server/
  25. starlark/
  26. swarming/
  27. tokenserver/
  28. tools/
  29. tumble/
  30. vpython/
  31. web/
  32. .gitattributes
  33. .travis.yml
  34. AUTHORS
  35. codereview.settings
  36. CONTRIBUTING.md
  37. CONTRIBUTORS
  38. LICENSE
  39. OWNERS
  40. pre-commit-go.yml
  41. PRESUBMIT.py
  42. README.md
README.md

luci-go: LUCI services and tools in Go

GoDoc

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

Contributing

Contributing uses the same flow as Chromium contributions.