Google Git
Sign in
chromium / infra / luci / luci-go / f85f9fe09f0bd0df9c068e161f7671651128e707
commitf85f9fe09f0bd0df9c068e161f7671651128e707[log] [tgz]
authorPatrick Meiring <meiring@google.com>Mon Jun 30 07:50:57 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jun 30 07:50:57 2025
tree1cd82048849bb457d1bc0efb2202389596d29415
parent310f86db3831ede7a383354f21547065bcb5bf6e [diff]
[ResultDB] Revise and extend validation methods, preparing for work units.

1. Adds validation methods for full resource names, work unit tags and
root invocation tags.

2. Strictens the validation for variants:
- There is now a size limit on the total size of a variant.
- Variant values are now required to be printable, valid UTF-8,
  and in Unicode Normalization Form C.

Backtesting the variant validation changes on the last 7 days of data
indicates they are safe to retrofit on all in-production uploaders.

3. Deprecates the properties_schema field under test metadata, moving
towards requiring a "@type" key in the properties blob itself. This
matches what was done for invocation extended properties.

BUG=b:428563342
TEST=Integration tests

Change-Id: I960c9152cb4471dbf82e82f34b0ef7aa6c50842a
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6688446
Reviewed-by: Beining Chen <beining@google.com>
Commit-Queue: Patrick Meiring <meiring@google.com>
20 files changed
tree: 1cd82048849bb457d1bc0efb2202389596d29415
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. lucichecker.py
  59. OWNERS
  60. PRESUBMIT.py
  61. README.md
  62. staticcheck.conf
  63. tools.go
  64. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.