Google Git
Sign in
chromium / infra / luci / luci-go / f8ef586be3d23c1fc0bea18c5857ba6792edf0a3
commitf8ef586be3d23c1fc0bea18c5857ba6792edf0a3[log] [tgz]
authorAnushruth <anushruth@google.com>Tue Feb 18 22:11:44 2025
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 18 22:11:44 2025
treeefbf7520f7f8360ffaa4b10401bfc81176184b52
parentce6df21394fd31e97dbbb579107b4c5b22604f2b [diff]
[gcep] Fix VM terminating logic in gce-provider

Bug: 395973590

This patch updates the logic to terminate the VMs in gcep. The old logic
ensured that the VMs would be killed if the swarming reported that the
bot was dead (IsDead)*. This causes issues if the VM is rebooting and
swarming lists it as dead. The new flow takes advantage of the field
termination_task_id in swarming bot field to address a few corner cases.
The new logic is as follows
        1. Bot is dead and has a termination_task_id
                Kill the VM
        3. Bot is dead and was last seen more than vm.Timeout ago
                Kill the VM

* All VMs are subject to a minPendingTime amnesty from this rule on
  their first boot (currently 10 minutes)

Change-Id: Ic6c6a3f96b9b7315fc427e6dd7bd2a6b7e7ce27d
Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6277626
Commit-Queue: Anushruth Sasivehalli <anushruth@chromium.org>
Reviewed-by: Gowri Denduluri <gowriden@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Anushruth Sasivehalli <anushruth@chromium.org>
1 file changed
tree: efbf7520f7f8360ffaa4b10401bfc81176184b52
  1. analysis/
  2. appengine/
  3. auth/
  4. auth_service/
  5. bisection/
  6. build/
  7. buildbucket/
  8. casviewer/
  9. cipd/
  10. cipkg/
  11. client/
  12. common/
  13. config/
  14. config_service/
  15. cv/
  16. deploy/
  17. examples/
  18. gae/
  19. gce/
  20. grpc/
  21. hardcoded/
  22. led/
  23. logdog/
  24. luci_notify/
  25. lucicfg/
  26. lucictx/
  27. luciexe/
  28. mailer/
  29. milo/
  30. mmutex/
  31. provenance/
  32. recipes_py/
  33. resultdb/
  34. scheduler/
  35. scripts/
  36. server/
  37. source_index/
  38. standalone/
  39. starlark/
  40. swarming/
  41. teams/
  42. third_party/
  43. tokenserver/
  44. tools/
  45. tree_status/
  46. vpython/
  47. web/
  48. .gitallowed
  49. .gitignore
  50. .go-lintable
  51. AUTHORS
  52. codereview.settings
  53. CONTRIBUTING.md
  54. CONTRIBUTORS
  55. go.mod
  56. go.sum
  57. LICENSE
  58. OWNERS
  59. PRESUBMIT.py
  60. README.md
  61. staticcheck.conf
  62. tools.go
  63. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoReference

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

It is now possible to directly install tools with go install:

go install go.chromium.org/luci/auth/client/cmd/...@latest
go install go.chromium.org/luci/buildbucket/cmd/...@latest
go install go.chromium.org/luci/cipd/client/cmd/...@latest
go install go.chromium.org/luci/client/cmd/...@latest
go install go.chromium.org/luci/cv/cmd/...@latest
go install go.chromium.org/luci/gce/cmd/...@latest
go install go.chromium.org/luci/grpc/cmd/...@latest
go install go.chromium.org/luci/logdog/client/cmd/...@latest
go install go.chromium.org/luci/luci_notify/cmd/...@latest
go install go.chromium.org/luci/lucicfg/cmd/...@latest
go install go.chromium.org/luci/luciexe/legacy/cmd/...@latest
go install go.chromium.org/luci/mailer/cmd/...@latest
go install go.chromium.org/luci/mmutex/cmd/...@latest
go install go.chromium.org/luci/resultdb/cmd/...@latest
go install go.chromium.org/luci/server/cmd/...@latest
go install go.chromium.org/luci/swarming/cmd/...@latest
go install go.chromium.org/luci/tokenserver/cmd/...@latest
go install go.chromium.org/luci/tools/cmd/...@latest

Contributing

Contributing uses the same flow as Chromium contributions.