Don't set custom warning flags in msgs_internal_config See comment on https://chromium-review.googlesource.com/c/openscreen/+/6457698 This config mostly exists to disable -Wshadow for one cc file. Instead, just build that one file as no_chromium_code. No effective behavior change. Bug: chromium:410803303 Change-Id: I952057f0a31f0a150926c55e65fd6ade89b93807 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6483407 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
diff --git a/osp/msgs/BUILD.gn b/osp/msgs/BUILD.gn index abb0aa9..26ef477 100644 --- a/osp/msgs/BUILD.gn +++ b/osp/msgs/BUILD.gn
@@ -17,50 +17,11 @@ public_deps = [ ":cddl_gen" ] deps = [ "../../third_party/tinycbor" ] - configs = [ ":msgs_internal_config" ] + remove_configs = [ "//build/config/compiler:chromium_code" ] + configs = [ "//build/config/compiler:no_chromium_code" ] public_configs = [ ":cddl_gen_config" ] } -config("msgs_internal_config") { - cflags = [] - - if (is_win) { - # /W4 on windows corresponds to gcc's -Wall; /Wall corresponds to -Weverything instead - cflags += [ "/W4" ] - } else { - cflags += [ "-Wall" ] - } - - if (is_clang) { - cflags += [ "-Wno-shadow" ] - } - - if (is_win) { - # On Windows, some of the libc++ reserved macros are incorrectly reported - # as errors. - cflags += [ - "-Wno-reserved-macro-identifier", - "-Wno-reserved-identifier", - "-Wno-c++98-compat", - "-Wno-c++98-compat-pedantic", - "-Wno-old-style-cast", - "-Wno-covered-switch-default", - "-Wno-missing-prototypes", - "-Wno-tautological-unsigned-zero-compare", - "-Wno-sign-conversion", - "-Wno-extra-semi-stmt", - "-Wno-dtor-name", - "-Wno-switch-default", - "-Wno-undef", - "-Wno-float-equal", - "-Wno-unsafe-buffer-usage", - "-Wno-unused-macros", - "-Wno-newline-eof", - "-Wno-implicit-int-conversion", - ] - } -} - config("cddl_gen_config") { include_dirs = [ "$root_gen_dir" + "/" + rebase_path("../..", "//") ] }