Google Git
Sign in
chromium / chromium / src / b9b02e0537eac358b8facb9802e16adce590f0ea
commitb9b02e0537eac358b8facb9802e16adce590f0ea[log] [tgz]
authorSylvain Defresne <sdefresne@chromium.org>Mon Feb 18 14:44:36 2019
committerCommit Bot <commit-bot@chromium.org>Mon Feb 18 14:44:36 2019
treef367bda396d5c60db6a29f6383469deb85aa5115
parent749c2dbf448f1e35a1a87df58ce09dbd2424e945 [diff]
Remove KeyedServiceBaseFactory::RegisterUserPrefsOnContextForTest

Remove obsolete method RegisterUserPrefsOnContextForTest from
KeyedServiceBaseFactory (tests should instead register the prefs
before creating instances of the services by using testing context
like TestingProfile or TestChromeBrowserState).

Also remove all supporting code present to ensure that the prefs
are not registered twice due to RegisterUserPrefsOnContextForTest
interaction with registration via DependencyManager.

Bug: 932534
Change-Id: Id49b802d9cc6818cb101b8b9697b274a9e5d2e3b
Reviewed-on: https://chromium-review.googlesource.com/c/1474938
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633091}
14 files changed
tree: f367bda396d5c60db6a29f6383469deb85aa5115
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .