components/cronet/android/cronet_base_feature_unittest.cc

// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "components/cronet/android/cronet_base_feature.h"
#include "base/feature_list.h"
#include "base/metrics/field_trial_params.h"
#include "base/test/scoped_feature_list.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace cronet {
namespace {

using ::org::chromium::net::httpflags::BaseFeatureOverrides;
using ::testing::IsEmpty;
using ::testing::Pair;
using ::testing::UnorderedElementsAre;

constexpr char kTestFeatureDisabledByDefaultName[] =
    "CronetBaseFeatureTestFeatureDisabledByDefault";
BASE_FEATURE(kTestFeatureDisabledByDefault,
             kTestFeatureDisabledByDefaultName,
             base::FEATURE_DISABLED_BY_DEFAULT);

constexpr char kTestFeatureEnabledByDefaultName[] =
    "CronetBaseFeatureTestFeatureEnabledByDefault";
BASE_FEATURE(kTestFeatureEnabledByDefault,
             kTestFeatureEnabledByDefaultName,
             base::FEATURE_ENABLED_BY_DEFAULT);

constexpr char kTestFeatureWithParamsName[] =
    "CronetBaseFeatureTestFeatureWithParams";
BASE_FEATURE(kTestFeatureWithParams,
             kTestFeatureWithParamsName,
             base::FEATURE_DISABLED_BY_DEFAULT);
constexpr char kTestParamName[] = "test_param";
constexpr char kTestParamDefaultValue[] = "test_param_default_value";
constexpr base::FeatureParam<std::string> kTestParam{
    &kTestFeatureWithParams, kTestParamName, kTestParamDefaultValue};

TEST(ApplyBaseFeatureOverrides, NoOpOnEmptyOverrides) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  ApplyBaseFeatureOverrides(BaseFeatureOverrides());
  EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
  EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}

TEST(ApplyBaseFeatureOverrides, OverridesFeatureToEnabled) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  (*overrides.mutable_feature_states())[kTestFeatureDisabledByDefaultName]
      .set_enabled(true);
  ApplyBaseFeatureOverrides(overrides);
  EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
}

TEST(ApplyBaseFeatureOverrides, OverridesFeatureToDisabled) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  (*overrides.mutable_feature_states())[kTestFeatureEnabledByDefaultName]
      .set_enabled(false);
  ApplyBaseFeatureOverrides(overrides);
  EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}

TEST(ApplyBaseFeatureOverrides, DoesNotOverrideFeature) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  (*overrides.mutable_feature_states())[kTestFeatureEnabledByDefaultName];
  ApplyBaseFeatureOverrides(overrides);
  EXPECT_TRUE(base::FeatureList::IsEnabled(kTestFeatureEnabledByDefault));
}

TEST(ApplyBaseFeatureOverrides, NoOpIfBaseFeatureAlreadyInitialized) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithEmptyFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  (*overrides.mutable_feature_states())[kTestFeatureDisabledByDefaultName]
      .set_enabled(true);
  ApplyBaseFeatureOverrides(overrides);
  EXPECT_FALSE(base::FeatureList::IsEnabled(kTestFeatureDisabledByDefault));
}

TEST(ApplyBaseFeatureOverrides,
     DoesNotAssociateFeatureParamsIfNoParamsAreProvided) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  (*overrides.mutable_feature_states())[kTestFeatureWithParamsName].set_enabled(
      true);
  ApplyBaseFeatureOverrides(overrides);
  base::FieldTrialParams params;
  EXPECT_FALSE(
      base::GetFieldTrialParamsByFeature(kTestFeatureWithParams, &params));
  EXPECT_THAT(params, IsEmpty());
  EXPECT_EQ(kTestParam.Get(), kTestParamDefaultValue);
}

TEST(ApplyBaseFeatureOverrides, AssociatesFeatureParams) {
  base::test::ScopedFeatureList scoped_feature_list;
  scoped_feature_list.InitWithNullFeatureAndFieldTrialLists();
  BaseFeatureOverrides overrides;
  constexpr char kParamValue[] = "test_param_value";
  auto& feature_state =
      (*overrides.mutable_feature_states())[kTestFeatureWithParamsName];
  feature_state.set_enabled(true);
  (*feature_state.mutable_params())[kTestParamName] = kParamValue;
  ApplyBaseFeatureOverrides(overrides);
  base::FieldTrialParams params;
  EXPECT_TRUE(
      base::GetFieldTrialParamsByFeature(kTestFeatureWithParams, &params));
  EXPECT_THAT(params, UnorderedElementsAre(Pair(kTestParamName, kParamValue)));
  EXPECT_EQ(kTestParam.Get(), kParamValue);
}

}  // namespace
}  // namespace cronet