commit | 2bb612f83f651e8dd692af90a30b69ccd79f7ce5 | [log] [tgz] |
---|---|---|
author | Peter Wen <wnwen@chromium.org> | Thu May 14 12:57:34 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 14 12:57:34 2020 |
tree | 7bba5b535c4d7e17d00e81c3ab3cc96963c35234 | |
parent | 4c546759348ad77b319b356d40d055c6910d7cde [diff] |
Android: Remove unused gn args for lint Remove min_sdk_version and android_manifest_for_lint GN variables. Remove the extra not_needed in internal_rules. It allowed time for downstream projects to remove these args from their gn templates. Commit after webrtc CL is merged into chromium: https://webrtc-review.googlesource.com/c/src/+/174983 Previously, min_sdk_version was used to package our apks and to pass to android lint for linting each java target. We've since migrated to minSdkVersion being specified in our AndroidManifest.xml (thus no longer using the GN min_sdk_version variable for apks). Since then it's only been used for linting each java target. I've migrated lint to only lint for apks and bundles, and so min_sdk_version is only necessary for apks and bundles, not for any other java target. Thus these GN variables are no longer used by non-apk/bundle java targets (GN complains about them being unused). Bug: 1017190 Change-Id: Ia75becae168fdd9151c91b14dc22e0c4ac5ca77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198608 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#768735} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 02bc8aadcc151150ff0304a49f5b2cd5c986826c
This folder contains a shim layer between the public frameworks APIs (android.webkit.*
) and WebView's implementation, and allows them to (mostly) not directly depend on each other.
//android_webview/java/
must not depend on this directory.