commit | dbc2f3dc217f4229802e4a1be30c7691b672c81a | [log] [tgz] |
---|---|---|
author | Nathan Memmott <memmott@chromium.org> | Fri Apr 26 19:17:33 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Apr 26 20:03:22 2024 |
tree | 97e16bc32999738c1e24c7b16863e1c28dea41b0 | |
parent | a60aa23971f6ba22e32e328a1eab1a896e2f94c9 [diff] |
[base] Clean up Windows base::FilePathWatcher This cleans up the Windows implementation of base::FilePathWatcher by: - Formatting code with git cl format - Use `WeakPtr` to detect deletion - Update some function and variable names to be clearer - Some other small non-functional that are cleaner This is in preparation to support WatchWithChangeInfo on Windows. Bug: 321980447 Change-Id: Iaffe6e3689f5c1c3432e7ead1ce7018333a73f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465325 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Nathan Memmott <memmott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1293186} NOKEYCHECK=True GitOrigin-RevId: 87cabe7ee282980e15b4b7d90ed561bd1591fa2e
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE
is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests
target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local
, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.