Sanitize reserved Windows names in dragged URL shortcut files When a URL is dragged out of Chrome on Windows, the virtual .url shortcut filename is derived from the link title. CreateValidFileNameFromTitle() already strips characters that are illegal in path components, but did not account for reserved Windows device names such as COM1, NUL or LPT1, so a title of "COM1" produced a virtual file named "COM1.url." On Windows 10[1], if drop targets call CreateFile without sanitizing this filename themselves, this could result in a direct write to a serial port[2]. At best this will no-op with return code, at worst this could hang the calling process if: 1. the serial port is written to while configured to block on CTS (Clear to Send) signal 2. It does not guard against 1. with timeout OSExchangeDataWin should not allow passing around reserved file names. Prepend an underscore when the generated name is reserved, mirroring net::GenerateSafeFileName(). [1] https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#handle-legacy-devices [2] https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#win32-device-namespaces Bug: 522560742 Change-Id: I2703475361fe0e7c6f7237696fee6b2cd6350bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8772748 Reviewed-by: Dan Clark <daniec@microsoft.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: John An <johna@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1748664} NOKEYCHECK=True GitOrigin-RevId: 952223dc1f0d38fbe36f24ba06f416a4977ed43c
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.
Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).
Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).
When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.
Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.