[AdTagging] Enforce one-way tagging and introduce FrameAdStatus Explicitly enforce one-way ad tagging in related APIs. The original code included support for untagging frames, but this functionality was never enabled, and we do not plan to support untagging any time soon. This CL removes the dead code to prevent confusion. To lay the groundwork for tracking additional ad sub-types (e.g., video ads), this CL also introduces the `FrameAdStatus` enum (`kNotAd`, `kAd`) and updates the internal frame replication state and `RemoteFrame` tagging API to use it. Note: `RenderFrameHostImpl::UpdateToAdFrame` is deliberately not updated to use this enum. It remains orthogonal to the upcoming video ad tagging code path: `UpdateToAdFrame()` is invoked from the component layer during the "ReadyToCommit" stage, whereas the upcoming `UpdateToVideoAdFrame()` will be invoked directly via `mojom.LocalFrameHost`. Bug: 552371621 Change-Id: If37556a4ee775e1098222ea1f951594726199098 Fuchsia-Binary-Size: Size increase is unavoidable. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8315747 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mingyu Lei <leimy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1689628} NOKEYCHECK=True GitOrigin-RevId: c58e0535873ecb7d50ad31c15899d1f89b3aa6df
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.
Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).
Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).
When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.
Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.