[Mac] Drain ready UI tasks before [NSApp run] and after finishLaunching This CL drains ready immediate UI tasks in `MessagePumpNSApplication` behind `MacPumpTasksBeforeFinishLaunching`: up to 18ms before `-[NSApplication run]` and up to 45ms after `finishLaunching` in `BrowserCrApplication`, without running idle work and while stopping immediately on `Quit()`. On macOS startup, `-[NSApplication run]` blocks the UI thread during `finishLaunching` (~21ms) and the first `_DPSNextEvent` (~33ms) before Chromium tasks run. Draining ready tasks across these phases lets queued GPU, frame sink, WebUI, and navigation work start earlier. When enabled, UI tasks (including an early shutdown) can now run before `applicationDidFinishLaunching:`. `AppController` teardown handles uninitialized state safely, `applicationDidFinishLaunching:` returns early if shutdown has already started, and video capture accepts a null `CFRunLoopMode` only during the startup drain (re-checking until a live mode is seen). Even with the feature disabled, `allowsAutomaticWindowTabbing` is set earlier before launch and nested `Run()` calls before `[NSApp run]` unwinds stay in their own loop. `mac-m1-pro-perf` `browser_startup.crossbench` (P50 median): - `Startup.BrowserWindow.FirstPaint`: -53ms (-14.1%, 378.0 -> 324.5ms) - `InitialWebUI.Startup.ReloadButton.FirstContentfulPaint`: -52ms (-12.7%, 411.5 -> 359.0ms) - `Startup.FirstWebContents.NonEmptyPaint3`: -37ms (-8.8%, 422.0 -> 385.0ms) Bug: 577828725 Change-Id: I354dd9b9fdd1265c755eddc6995783e35a8ad98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8650420 Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1748237} NOKEYCHECK=True GitOrigin-RevId: 6d64b86fac78f7f3c9e2144ae36d134a1c3de4ba
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.
Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).
Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).
When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.
Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.