[3p freshness] double_conversion: Move upstream code into src/
- Move LICENSE and double-conversion/ into src/ with git mv, no byte
change. docs/adding_to_third_party.md#standard-dep-structure wants
the imported code in src/ and glue at the top. Upstream has the
same two entries at its root at 32bc443c60c8, the README Revision,
so src/ mirrors it:
# in a clone of https://github.com/google/double-conversion:
$ git ls-tree --name-only 32bc443c60c8 -- LICENSE double-conversion
LICENSE
double-conversion
- BUILD.gn sources and README.chromium License File point into src/.
- Update the three #includes of double-conversion.h: base/strings
and blink's wtf dtoa.cc and text/format.cc.
- build/linux/unbundle/double-conversion.gn: root_path is now "src",
so the shim headers for a system double-conversion land on the new
include path:
$ build/linux/unbundle/replace_gn_files.py \
--system-libraries double-conversion
$ gn gen out/unbundle-dc
$ gn desc out/unbundle-dc \
//base/third_party/double_conversion:gen_double_conversion_shim \
outputs | grep -o 'double_conversion/src/.*'
double_conversion/src/double-conversion/bignum.h
...
double_conversion/src/double-conversion/double-conversion.h
...
- tools/clang/scripts/apply_edits_test.py: update the path in a
comment that names utils.h.
- Add .clang-format-ignore for src/**. Unlike third_party/,
base/third_party has no format ignore, and git cl format otherwise
reformats the moved upstream files.
Bug: 502791241
Change-Id: If014176b51f3088190627a8792f5be9db2f48965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8576840
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1719370}
NOKEYCHECK=True
GitOrigin-RevId: 87bc981cce981d520cca7fa3b7f497f335053995
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.
Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).
Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).
When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.
Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.