commit: dca811cad767ac1af000d4bba326429146f94856
[log]
author: Andrew Grieve <agrieve@chromium.org>
Tue Jun 16 20:18:39 2026
committer: Copybara-Service <copybara-worker@google.com>
Tue Jun 16 20:20:13 2026
tree: 88bfae0d39fd6c7815902474a103fbe628350d69
parent: 332899b65fe081eaadc91cb31e0250a19196aef3 [diff]

Reland "Android: Set extractNativeLibs="false" by default for apk targets"

This reverts commit 41e92a54a8fcc5c258b8e41d7d6ad44990cb7aef.

Reason for reland: Fix landed in https://crrev.com/c/7952581

Original change's description:
> Revert "Android: Set extractNativeLibs="false" by default for apk targets"
>
> This reverts commit 5a1a32db6c745921f7e7cf90362ab91a329469d1.
>
> Reason for revert: Breaking VR apk
>
> Failure Link: https://ci.chromium.org/ui/p/chromium/builders/try/android-arm64-rel/1497497/overview
>
> Original change's description:
> > Android: Set extractNativeLibs="false" by default for apk targets
> >
> > This was already the default for bundle targets, since bundletool sets
> > it.
> >
> > This will reduce disk requirements by not extracting .so files in test
> > .apks when installing them.
> >
> > Bug: 516808390
> > Change-Id: I555343ae27c932d94d96176659686468ce2adfe1
> > Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7869175
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Owners-Override: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1646982}
>
> Bug: 516808390
> Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Ib3959b8d6a7a892c929cdf148dc968dbc892759e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7952140
> Commit-Queue: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1647597}

Bug: 516808390
Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
Change-Id: I01699ba1a67df04ad441315438ccd10d3a66e5e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7952042
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1647846}
NOKEYCHECK=True
GitOrigin-RevId: 4f4d0ed7e251f9fd123e4fad947388f3b867f81d

4 files changed

tree: 88bfae0d39fd6c7815902474a103fbe628350d69

README.md

What is this

Contains a written down set of principles and other information on //base. Please add to it!

About //base:

Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.

The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.

Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.

If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.

base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.

Qualifications for being in //base OWNERS

interest and ability to learn low level/high detail/complex c++ stuff
inclination to always ask why and understand everything (including external interactions like win32) rather than just hoping the author did it right
mentorship/experience
demonstrated good judgement (esp with regards to public APIs) over a length of time

Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.

Design and naming

Be sure to use the base namespace.
STL-like constructs should adhere as closely to STL as possible. Functions and behaviors not present in STL should only be added when they are related to the specific data structure implemented by the container.
For STL-like constructs our policy is that they should use STL-like naming even when it may conflict with the style guide. So functions and class names should be lower case with underscores. Non-STL-like classes and functions should use Google naming.

Performance testing

Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:

BasicPostTaskPerfTest: Exercises MessageLoopTaskRunner's multi-threaded queue in isolation.
ConditionVariablePerfTest: Measures thread switching cost of condition variables.
IntegratedPostTaskPerfTest: Exercises the full MessageLoop/RunLoop machinery.
JSONPerfTest: Tests JSONWriter and JSONReader performance.
MessageLoopPerfTest: Measures the speed of task posting in various configurations.
ObserverListPerfTest: Exercises adding, removing and signalling observers.
PartitionLockPerfTest: Tests the implementation of Lock used in PartitionAlloc
PthreadEventPerfTest: Establishes the baseline thread switching cost using pthreads.
RandUtilPerfTest: Measures the time it takes to generate random numbers.
ScheduleWorkTest: Measures the overhead of MessagePump::ScheduleWork.
SequenceManagerPerfTest: Benchmarks SequenceManager scheduling with various underlying task runners.
TaskObserverPerfTest: Measures the incremental cost of adding task observers.
TaskPerfTest: Checks the cost of posting tasks between threads.
ThreadLocalStoragePerfTest: Exercises different mechanisms for accessing data associated with the current thread (C++ thread_local, the implementation in //base, the POSIX/WinAPI directly)
WaitableEvent{Thread,}PerfTest: Measures waitable events in single and multithreaded scenarios.

Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.

Rust code

Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).

Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).

When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.

Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.