[Android] Forgive AppNotIdleException in ForgivingClickAction Espresso's UiController.injectMotionEvent() injects the event, reads the injection result, and only then calls loopMainThreadUntilIdle(). Its QueueInterrogator considers the main looper idle only when the queue is empty, blocked on a sync barrier, or the head message is due more than 15ms out. A 60Hz vsync is 16.6ms, so work that reposts itself every frame keeps the queue pinned in TASK_DUE_SOON. On Android Desktop, opening a new Incognito window keeps the queue in that state long enough for Espresso to give up, and it throws AppNotIdleException from a wait that was not needed: the MotionEvent had already been delivered and its result already read. The backlog is transient rather than permanent, since later interactions in the same test proceed normally once it drains. Treat an AppNotIdleException raised after the UP event was injected as a successful tap and let the caller's own conditions decide whether the UI arrived. Exceptions raised before the UP event are still propagated, since no UP or CANCEL was sent and the gesture would be left open. Tap.SINGLE also waits 1.5 * tapTimeout after sendUp() returns, and Tap.LONG waits before sendUp() to hold the press, so the two are distinguished rather than forgiven alike. This change is limited to the test infrastructure. Re-enabling the Desktop tests it unblocks is left to a follow-up, so that a flaky re-enable cannot force a revert of the fix itself. Bug: 536995089 Change-Id: I37f1ef870f74e143d0c095123f4a3a8c2b714c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8167480 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/main@{#1701342} NOKEYCHECK=True GitOrigin-RevId: b04883b18dd2cca6863d9041d801bf80ab90fb73
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.
Rust code in base should be organized into very small crates, split up by function. Merging crates is sometimes unavoidable (due to dependency cycles or the orphaning rule).
Rust files should live near the equivalent C++ files (if any), and use the same naming scheme (for example, run_loop.rs, not run_loop_rust.rs).
When adding FFI shims, prefer separate _shim.h files rather than adding code to existing C++ files. This helps avoid circular dependencies with the //base target. It also avoids adding code to commonly-used headers, which can increase compile size by a lot.
Crates which you expect to be widely used should be added to the public_deps of the //base:base_rust target, so that developers can simply depend on //base:base_rust the same way they do with //base.