Revert "Reland #3: "Android: Make TrichromeLibrary.apk have no classes.dex""
This reverts commit c469194504814fbbb8b8ede11180e71f8ad7606b.
Reason for revert: http://crbug.com/1331265
Original change's description:
> Reland #3: "Android: Make TrichromeLibrary.apk have no classes.dex"
>
> This reverts commit 735646fe6dca5e96de04e6361ff953e678a383f7.
>
> Reason for reland: SuperSize updated to not break with this change (see bug)
>
> Original change's description:
> > Revert "Reland #2: "Android: Make TrichromeLibrary.apk have no classes.dex""
> >
> > This reverts commit 78b77df7c29110fded5f0d9dec9ac68688baabae.
> >
> > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1330810
> >
> > Original change's description:
> > > Reland #2: "Android: Make TrichromeLibrary.apk have no classes.dex"
> > >
> > > This reverts commit debd9f8f82ef5e5c43828abeb7193c803d52c07d.
> > >
> > > Reason for reland: no longer archiving mapping files (see bug).
> > >
> > > Original change's description:
> > > > Revert "Reland "Reland "Android: Make TrichromeLibrary.apk have no classes.dex"""
> > > >
> > > > This reverts commit 95419d1c39897e4f2824265075c1dc0292acfb9f.
> > > >
> > > > Reason for revert: Breaking builds crbug/1329728
> > > >
> > > > Original change's description:
> > > > > Reland "Reland "Android: Make TrichromeLibrary.apk have no classes.dex""
> > > > >
> > > > > This reverts commit 807fc51745a18c9869e55da0e105480b56af774c.
> > > > >
> > > > > Reason for revert: Stub generation changed so won't break.
> > > > >
> > > > > Original change's description:
> > > > > > Revert "Reland "Android: Make TrichromeLibrary.apk have no classes.dex""
> > > > > >
> > > > > > This reverts commit 3d1dd9017a9dac36f8cdedc084f10ccb56db433d.
> > > > > >
> > > > > > Reason for revert: Speculative revert from clank Trichrome apk error, see crbug.com/1328926
> > > > > >
> > > > > > Original change's description:
> > > > > > > Reland "Android: Make TrichromeLibrary.apk have no classes.dex"
> > > > > > >
> > > > > > > This reverts commit 293df39872b775e1223c86c1a6863f50f06c4fbc.
> > > > > > >
> > > > > > > Reason for reland: Fixed system_webview_no_weblayer_apk
> > > > > > >
> > > > > > > Original change's description:
> > > > > > > > Revert "Android: Make TrichromeLibrary.apk have no classes.dex"
> > > > > > > >
> > > > > > > > This reverts commit b1e26665ad91606db1ade9fe8f021ef7dbbe879a.
> > > > > > > >
> > > > > > > > Reason for revert:
> > > > > > > > Findit (https://goo.gl/kROfz5) identified this CL at revision b1e26665ad91606db1ade9fe8f021ef7dbbe879a as
> > > > > > > > the culprit for failures in the continuous build including:
> > > > > > > >
> > > > > > > > Sample Failed Build: https://ci.chromium.org/b/8813697873572499617
> > > > > > > > Sample Failed Step: compile
> > > > > > > >
> > > > > > > > If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2Fb1e26665ad91606db1ade9fe8f021ef7dbbe879a&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+b1e26665ad91606db1ade9fe8f021ef7dbbe879a
> > > > > > > >
> > > > > > > > Original change's description:
> > > > > > > > > Android: Make TrichromeLibrary.apk have no classes.dex
> > > > > > > > >
> > > > > > > > > Moves NativeLibraries class from the library to chrome/webview apks.
> > > > > > > > >
> > > > > > > > > This will allow better R8 optimization of the class, and should also
> > > > > > > > > hopefully result in better performance since the library should no
> > > > > > > > > longer need to be included in classloader lookups.
> > > > > > > > >
> > > > > > > > > Bug: 1319967
> > > > > > > > > Change-Id: I2c5908e6c575c9bce8c606506779e7db89f3269a
> > > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3650992
> > > > > > > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > > > > > > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > > > > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > > > > > > Cr-Commit-Position: refs/heads/main@{#1005425}
> > > > > > > >
> > > > > > > >
> > > > > > > > Change-Id: Ief1ae992169e351c2f70dcb6da8adb234e5106a8
> > > > > > > > No-Presubmit: true
> > > > > > > > No-Tree-Checks: true
> > > > > > > > No-Try: true
> > > > > > > > Bug: 1319967
> > > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3656342
> > > > > > > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > > > > > > Owners-Override: Andrew Grieve <agrieve@chromium.org>
> > > > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > > > > > Cr-Commit-Position: refs/heads/main@{#1005577}
> > > > > > >
> > > > > > > Bug: 1319967
> > > > > > > Change-Id: Ie06eab28a62bfa24420f1395358cae6b1dd7c640
> > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3654798
> > > > > > > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > > > > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > > > > Cr-Commit-Position: refs/heads/main@{#1006984}
> > > > > >
> > > > > > Bug: 1319967
> > > > > > Change-Id: Ib206849260a258a802f800c8762a79b2b372bd68
> > > > > > No-Presubmit: true
> > > > > > No-Tree-Checks: true
> > > > > > No-Try: true
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3664288
> > > > > > Commit-Queue: Sky Malice <skym@chromium.org>
> > > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > > > > Auto-Submit: Sky Malice <skym@chromium.org>
> > > > > > Owners-Override: Sky Malice <skym@chromium.org>
> > > > > > Cr-Commit-Position: refs/heads/main@{#1007069}
> > > > >
> > > > > Bug: 1319967
> > > > > Change-Id: I9987d23d7892dada08ef17fb1741cae3080c4dbd
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3669563
> > > > > Owners-Override: Andrew Grieve <agrieve@chromium.org>
> > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > > Cr-Commit-Position: refs/heads/main@{#1007970}
> > > >
> > > > Bug: 1319967, 1329728
> > > > Change-Id: I1aa906b250e1e0d3fc7d1415d9f26d00277157ba
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3671238
> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > > Owners-Override: Ben Mason <benmason@chromium.org>
> > > > Commit-Queue: Ben Mason <benmason@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1008186}
> > >
> > > Bug: 1319967, 1329728
> > > Change-Id: I39429bdd8563f6ebe13162a22a224ba150b7a0ce
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3679794
> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Andrew Grieve <agrieve@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1009301}
> >
> > Bug: 1319967, 1329728
> > Change-Id: If28eca41088ce7772643a2b37e8bddc6fbcb956d
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3683147
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1009538}
>
> Bug: 1319967, 1329728
> Change-Id: I2af42a2b4778d3a06d07a83fd354433b16865b92
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3684310
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Auto-Submit: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1009808}
Bug: 1319967, 1329728
Change-Id: I56809b324b835ce3c65a49e6bf36fef6b7516e4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3686752
Owners-Override: Egor Pasko <pasko@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Reviewed-by: Benoit Lize <lizeb@chromium.org>
Commit-Queue: Benoit Lize <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1010044}
NOKEYCHECK=True
GitOrigin-RevId: f71750c3dfa25802d027a940ecf6460207f93406
1 file changed
