commit | 227cd29ca8852ad459ca13eac6b72b38b318fbb3 | [log] [tgz] |
---|---|---|
author | Max Moroz <mmoroz@chromium.org> | Thu Dec 07 23:35:41 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 07 23:35:41 2017 |
tree | 258ec8722d1057d1100d59a91f856595fada720e | |
parent | 634ff7dc63d716f574400831298219f70d820abc [diff] |
Revert "Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true." This reverts commit c1406d52464e16da16aae9cb189c4f28e6412358. Reason for revert: The builds are failing on linking of some fuzzers: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FLibfuzzer_Upload_Linux_ASan%2F7088%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true. > > -fsanitize=fuzzer and -fsanitize=fuzzer-no-link are two compilation > flags that enable coverage instrumentation needed for libFuzzer. > > The instrumentation has more stuff under the hood compared to > -fsanitize=trace-pc-guard. Also, it can be changing over time > without a need to update GN flags again and again (e.g. move from > edge to trace-pc-guard or something like that). > > Bug: 764514 > Change-Id: I48ef328dee49a9620a1b44bd5cd920f116e1bc1b > Reviewed-on: https://chromium-review.googlesource.com/802395 > Commit-Queue: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522505} TBR=kcc@chromium.org,inferno@chromium.org,dpranke@chromium.org,ochang@chromium.org,mmoroz@chromium.org Change-Id: I86f316ba7b13c6cb015a3245e3860047ab4859ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764514 Reviewed-on: https://chromium-review.googlesource.com/815460 Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522615} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 8181cec6f208b34465eaacb64e247a1fcce9bcd6