Google Git
Sign in
chromium / chromium / src / third_party / WebKit / Source / wtf / 16ea89f90d5b360ec8dc484ec0e93ffe6eab63ae
commit16ea89f90d5b360ec8dc484ec0e93ffe6eab63ae[log] [tgz]
authorcsharrison <csharrison@chromium.org>Tue Jan 17 13:04:17 2017
committerCommit bot <commit-bot@chromium.org>Tue Jan 17 13:04:17 2017
tree5eb186055d8c7cd0c9863f51f62389b78e8476b5
parentcef61d30f2a3b1366bd2721dd2eaa275e0c346d0 [diff]
Avoid infinite recursion in StringImpl::asciiForDebugging

If any of the DCHECKs are hit in ref/deref/hasOneRef, then calling
substring() on the underlying impl can also trigger DCHECKs, causing
infinite recursion.

BUG=681581

Review-Url: https://codereview.chromium.org/2635033002
Cr-Original-Commit-Position: refs/heads/master@{#444035}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 965f6c6f71cd704f638caf664c591986a5d8df53
1 file changed
tree: 5eb186055d8c7cd0c9863f51f62389b78e8476b5
  1. allocator/
  2. debug/
  3. dtoa/
  4. testing/
  5. text/
  6. typed_arrays/
  7. .gitignore
  8. AddressSanitizer.h
  9. Alignment.h
  10. Allocator.h
  11. Allocator.md
  12. ASCIICType.cpp
  13. ASCIICType.h
  14. ASCIICTypeTest.cpp
  15. Assertions.cpp
  16. Assertions.h
  17. AssertionsTest.cpp
  18. Atomics.h
  19. AutoReset.h
  20. BitVector.cpp
  21. BitVector.h
  22. BitwiseOperations.h
  23. BloomFilter.h
  24. BUILD.gn
  25. build_config.h
  26. ByteOrder.h
  27. ByteSwap.h
  28. CheckedNumeric.h
  29. Compiler.h
  30. ConditionalDestructor.h
  31. ContainerAnnotations.h
  32. CONTRIBUTORS.pthreads-win32
  33. CPU.h
  34. CryptographicallyRandomNumber.cpp
  35. CryptographicallyRandomNumber.h
  36. CurrentTime.cpp
  37. CurrentTime.h
  38. DataLog.cpp
  39. DataLog.h
  40. DateMath.cpp
  41. DateMath.h
  42. DEPS
  43. Deque.h
  44. DequeTest.cpp
  45. DoublyLinkedList.h
  46. dtoa.cpp
  47. dtoa.h
  48. dtoa_test.cpp
  49. DynamicAnnotations.cpp
  50. DynamicAnnotations.h
  51. FilePrintStream.cpp
  52. FilePrintStream.h
  53. Forward.h
  54. Functional.h
  55. FunctionalTest.cpp
  56. GetPtr.h
  57. HashCountedSet.h
  58. HashFunctions.h
  59. HashIterators.h
  60. HashMap.h
  61. HashMapTest.cpp
  62. HashSet.h
  63. HashSetTest.cpp
  64. HashTable.cpp
  65. HashTable.h
  66. HashTableDeletedValueType.h
  67. HashTraits.h
  68. HexNumber.h
  69. InstanceCounter.cpp
  70. InstanceCounter.h
  71. LeakAnnotations.h
  72. LinkedHashSet.h
  73. LinkedStack.h
  74. ListHashSet.h
  75. ListHashSetTest.cpp
  76. Locker.h
  77. MathExtras.h
  78. MathExtrasTest.cpp
  79. Noncopyable.h
  80. NonCopyingSort.h
  81. NotFound.h
  82. Optional.h
  83. OptionalTest.cpp
  84. OWNERS
  85. PassRefPtr.h
  86. PassRefPtrTest.cpp
  87. PrintStream.cpp
  88. PrintStream.h
  89. PtrUtil.h
  90. RefCounted.h
  91. RefPtr.h
  92. RefPtrTest.cpp
  93. RefVector.h
  94. RetainPtr.h
  95. SaturatedArithmetic.h
  96. ScopedLogger.md
  97. SizeAssertions.h
  98. SizeLimits.cpp
  99. SpinLock.h
  100. StaticConstructors.h
  101. StdLibExtras.h
  102. StringExtras.h
  103. StringExtrasTest.cpp
  104. StringHasher.h
  105. StringHasherTest.cpp
  106. TerminatedArray.h
  107. TerminatedArrayBuilder.h
  108. Threading.h
  109. ThreadingPrimitives.h
  110. ThreadingPthreads.cpp
  111. ThreadingWin.cpp
  112. ThreadRestrictionVerifier.h
  113. ThreadSafeRefCounted.h
  114. ThreadSpecific.h
  115. ThreadSpecificWin.cpp
  116. Time.h
  117. TimeTest.cpp
  118. TreeNode.h
  119. TreeNodeTest.cpp
  120. TriState.h
  121. TypeTraits.h
  122. TypeTraitsTest.cpp
  123. UniquePtrTransitionGuide.md
  124. Vector.h
  125. VectorTest.cpp
  126. VectorTraits.h
  127. WeakPtr.h
  128. WTF.cpp
  129. WTF.h
  130. WTFExport.h
  131. WTFThreadData.cpp
  132. WTFThreadData.h