| commit | 10906a154860653a7a6ae7c94b30cd01af59c6c5 | [log] [tgz] |
|---|---|---|
| author | Mao Huang <littlecvr@chromium.org> | Tue Jul 31 19:34:52 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Jul 31 19:34:52 2018 |
| tree | a0662c3615ac20faf2aba52e5e7e6925e015eb5a | |
| parent | c3887ae077c0de11317a980cb08a7432d294d721 [diff] |
tcmalloc: Let DEFINE_string define char arrays. Original CL: - https://codereview.chromium.org/286953011 tcmalloc: Let DEFINE_string define const char*s. DEFINE_string is used in 3 files in tcmalloc, but we only compile one of these. In this one file, the string is converted to char every time it's used, and since the string is used after global destructors have run it needs to be copied to a second string in a static initializer. Instead of all that silliness, just let DEFINE_string define a const char* (like it does in v8 or webrtc). BUG=94925 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271307 BUG=724399,b:70905156 Change-Id: Iec6efe53f03daff472107e700a9d833d60e33eff Reviewed-on: https://chromium-review.googlesource.com/1130781 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#579528} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: fa774e229e1bbcbd53f406cb2e26e3f6fd4afa56