| commit | b0f78c43e502f68a4656088a308ca14e0cd6141f | [log] [tgz] |
|---|---|---|
| author | gab <gab@chromium.org> | Wed Feb 08 19:15:29 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Feb 08 19:15:29 2017 |
| tree | cae894225e0889c8a49b74243ab2292e90ad3eeb | |
| parent | ec3b723b6abe24aafd0f13d40a32b495f2d6b846 [diff] |
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1 id:1 of https://codereview.chromium.org/2685933002/ ) Reason for revert: Revert fixed WebKit Android (Nexus4) but... I also reverted https://codereview.chromium.org/2680943003 in parallel as EST sheriff... so now we don't know which one fixed it... tentatively relanding this one to see..! Original issue's description: > Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4 id:60001 of https://codereview.chromium.org/2633593004/ ) > > Reason for revert: > Speculative revert, potential culprit for webkit_tests crashing on "WebKit Android (Nexus4)". > > Stack traces show not much else than JNI managed->native transitions and syscalls. > > Original issue's description: > > Android: Use linker script to hide all non-JNI symbols > > > > The linker script is applied to all shared_library() targets by default, > > just like the hide_jni one was. > > > > This reduces the size of libchrome.so by 220kb. > > > > BUG=448386 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > > > Review-Url: https://codereview.chromium.org/2633593004 > > Cr-Commit-Position: refs/heads/master@{#448988} > > Committed: https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e5124fbd62bdd215 > > TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=448386 > > Review-Url: https://codereview.chromium.org/2685933002 > Cr-Commit-Position: refs/heads/master@{#449028} > Committed: https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da25e05a871efe TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromium.org,engedy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448386 Review-Url: https://codereview.chromium.org/2683013002 Cr-Original-Commit-Position: refs/heads/master@{#449057} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 59e1841b41f8902a0f300eb8cc412a73725013ed