Simplify SourceLocation classification and remove banned namespace check
The plugin was passing a clang::Decl* to ClassifyLocation() to classify
declarations in the blink or WTF namespace correctly. However, there is
now a set plan for the Blink file rename, so just check for the paths
directly. This simplifies the warning code by not requiring a Decl
to be passed around.
In addition, the plugin also implemented a check for banned namespaces
which checked for the C++ standard library public and implementation
namespaces. This is unnecessary since the plugin already knows how to
ignore warnings in system headers: removing this and relying on the
standard ClassifyLocation() check revealed one instance of inheriting
a class from the standard library and forgetting to mark the destructor
with override.
Bug: 706466
Change-Id: Ic12b1bc1fc47202026a2857b5eee10f5a7c3496d
Reviewed-on: https://chromium-review.googlesource.com/669711
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502782}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7b2f6fee2431924b8231846e7efd1584dfab27394 files changed
