Migrate TODOs referencing old crbug IDs to the new issue tracker IDs
The canonical bug format is TODO(crbug.com/<id>). TODOs of the
following forms will all be migrated to the new format:
- TODO(crbug.com/<old id>)
- TODO(https://crbug.com/<old id>)
- TODO(crbug/<old id>)
- TODO(crbug/monorail/<old id>)
- TODO(<old id>)
- TODO(issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/<old id>)
- TODO(https://issues.chromium.org/u/1/issues/<old id>)
- TODO(bugs.chromium.org/<old id>)
Bug id mapping is sourced from go/chrome-on-buganizer-prod-issues.
See go/crbug-todo-migration for details.
#crbug-todo-migration
Bug: b/321899722
Change-Id: Ib4e61022cc4ca4f0a6563a63fb5d2f582ef930c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5494425
Auto-Submit: Alison Gale <agale@chromium.org>
Owners-Override: Alison Gale <agale@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293183}
NOKEYCHECK=True
GitOrigin-RevId: 4d9c23185ad9f590658e36154ac3e53f0f4f158b
diff --git a/iterator_checker/IteratorChecker.cpp b/iterator_checker/IteratorChecker.cpp
index d240feb..3917902 100644
--- a/iterator_checker/IteratorChecker.cpp
+++ b/iterator_checker/IteratorChecker.cpp
@@ -41,7 +41,7 @@
// GCC-style attributes and pragmas that can help make using the Clang Static
// Analyzer useful. We aim to provide support for those annotations. For now, we
// hard code those for "known" interesting classes.
-// TODO(https://crbug.com/1455371) Support source-level annotations.
+// TODO(crbug.com/40272746) Support source-level annotations.
enum Annotation : uint8_t {
kNone = 0,
@@ -54,7 +54,7 @@
kReturnEndIterator = 1 << 1,
// Annotate function returning a pair of iterators.
- // TODO(https://crbug.com/1455371) Not yet implemented.
+ // TODO(crbug.com/40272746) Not yet implemented.
kReturnIteratorPair = 1 << 2,
// Annotate function invalidating the iterator in its arguments.
@@ -72,7 +72,7 @@
{"std::next", Annotation::kReturnIterator},
{"std::prev", Annotation::kReturnIterator},
{"std::find", Annotation::kReturnIterator},
- // TODO(https://crbug.com/1455371) Add additional functions.
+ // TODO(crbug.com/40272746) Add additional functions.
};
static llvm::DenseMap<llvm::StringRef, llvm::DenseMap<llvm::StringRef, uint8_t>>
@@ -134,7 +134,7 @@
Annotation::kInvalidateArgs | Annotation::kReturnIterator},
{"extract", Annotation::kInvalidateArgs},
{"find", Annotation::kReturnIterator},
- // TODO(https://crbug.com/1455371) Add additional functions.
+ // TODO(crbug.com/40272746) Add additional functions.
},
},
{
@@ -159,7 +159,7 @@
// `pop_back` invalidates only the iterator pointed to the last
// element, but we have no way to track it.
{"pop_back", Annotation::kNone},
- // TODO(https://crbug.com/1455371) Add additional functions.
+ // TODO(crbug.com/40272746) Add additional functions.
},
},
{
@@ -183,7 +183,7 @@
{"emplace_back", Annotation::kInvalidateAll},
{"push_front", Annotation::kInvalidateAll},
{"emplace_front", Annotation::kInvalidateAll},
- // TODO(https://crbug.com/1455371) Add additional functions.
+ // TODO(crbug.com/40272746) Add additional functions.
},
},
};
@@ -367,7 +367,7 @@
return;
}
- // TODO(https://crbug.com/1455371): Add support for operator[]
+ // TODO(crbug.com/40272746): Add support for operator[]
// (ArraySubscriptExpr)
}
@@ -502,7 +502,7 @@
if (annotation & Annotation::kInvalidateArgs) {
bool found_iterator = false;
- // TODO(https://crbug.com/1455371): Invalid every arguments.
+ // TODO(crbug.com/40272746): Invalid every arguments.
for (unsigned i = 0; i < callexpr.getNumArgs(); i++) {
if (auto* iterator = UnwrapAsIterator(callexpr.getArg(i), env)) {
InfoStream() << "INVALIDATING ONE: " << DebugString(env, *iterator)
@@ -538,7 +538,7 @@
}
if (annotation & Annotation::kReturnIteratorPair) {
- // TODO(https://crbug.com/1455371): Iterator pair are not yet supported.
+ // TODO(crbug.com/40272746): Iterator pair are not yet supported.
}
}
@@ -672,7 +672,7 @@
return;
}
- // TODO(https://crbug.com/1455371) Handle other kinds of operators.
+ // TODO(crbug.com/40272746) Handle other kinds of operators.
}
// CastExpr: https://clang.llvm.org/doxygen/classclang_1_1CastExpr.html
diff --git a/plugins/RawPtrHelpers.cpp b/plugins/RawPtrHelpers.cpp
index ba12533..deeba17 100644
--- a/plugins/RawPtrHelpers.cpp
+++ b/plugins/RawPtrHelpers.cpp
@@ -184,7 +184,7 @@
clang::ast_matchers::internal::Matcher<clang::Decl> AffectedRawPtrFieldDecl(
const RawPtrAndRefExclusionsOptions& options) {
- // TODO(crbug.com/1381955): Skipping const char pointers as it likely points
+ // TODO(crbug.com/40245402): Skipping const char pointers as it likely points
// to string literals where raw_ptr isn't necessary. Remove when we have
// implement const char support.
auto const_char_pointer_matcher = fieldDecl(hasType(
diff --git a/rewrite_raw_ptr_fields/tests/affected-expr-expected.cc b/rewrite_raw_ptr_fields/tests/affected-expr-expected.cc
index ed66886..a36bedf 100644
--- a/rewrite_raw_ptr_fields/tests/affected-expr-expected.cc
+++ b/rewrite_raw_ptr_fields/tests/affected-expr-expected.cc
@@ -274,7 +274,7 @@
std::string other_str = "other";
// No rewrite expected. (for now)
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
bool v1 = my_struct.const_char_ptr == other_str;
bool v2 = other_str == my_struct.const_char_ptr;
bool v3 = my_struct.const_char_ptr > other_str;
@@ -470,7 +470,7 @@
MyStruct my_struct(s, s, s);
// No rewrite expected. (for now)
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
FunctionTakingBasicStringPiece(my_struct.const_char_ptr);
FunctionTakingBasicStringPieceRef(my_struct.const_char_ptr);
diff --git a/rewrite_raw_ptr_fields/tests/affected-expr-original.cc b/rewrite_raw_ptr_fields/tests/affected-expr-original.cc
index 482e800..e935f94 100644
--- a/rewrite_raw_ptr_fields/tests/affected-expr-original.cc
+++ b/rewrite_raw_ptr_fields/tests/affected-expr-original.cc
@@ -271,7 +271,7 @@
std::string other_str = "other";
// No rewrite expected. (for now)
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
bool v1 = my_struct.const_char_ptr == other_str;
bool v2 = other_str == my_struct.const_char_ptr;
bool v3 = my_struct.const_char_ptr > other_str;
@@ -467,7 +467,7 @@
MyStruct my_struct(s, s, s);
// No rewrite expected. (for now)
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
FunctionTakingBasicStringPiece(my_struct.const_char_ptr);
FunctionTakingBasicStringPieceRef(my_struct.const_char_ptr);
diff --git a/rewrite_raw_ptr_fields/tests/gen-unions-test.cc b/rewrite_raw_ptr_fields/tests/gen-unions-test.cc
index 942539c..86ff540 100644
--- a/rewrite_raw_ptr_fields/tests/gen-unions-test.cc
+++ b/rewrite_raw_ptr_fields/tests/gen-unions-test.cc
@@ -29,7 +29,7 @@
union MyUnion1 {
SomeClass* some_class_ptr;
char* char_ptr;
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
const char* const_char_ptr;
};
diff --git a/rewrite_raw_ptr_fields/tests/various-types-expected.cc b/rewrite_raw_ptr_fields/tests/various-types-expected.cc
index e00af1a..51e1d11 100644
--- a/rewrite_raw_ptr_fields/tests/various-types-expected.cc
+++ b/rewrite_raw_ptr_fields/tests/various-types-expected.cc
@@ -120,7 +120,7 @@
raw_ptr<uint8_t> unsigned_char_ptr;
raw_ptr<int8_t> signed_char_ptr;
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
//
// No rewrite expected (for now).
const char* const_char_ptr;
diff --git a/rewrite_raw_ptr_fields/tests/various-types-original.cc b/rewrite_raw_ptr_fields/tests/various-types-original.cc
index 46af08e..d0973a3 100644
--- a/rewrite_raw_ptr_fields/tests/various-types-original.cc
+++ b/rewrite_raw_ptr_fields/tests/various-types-original.cc
@@ -117,7 +117,7 @@
uint8_t* unsigned_char_ptr;
int8_t* signed_char_ptr;
- // TODO(crbug.com/1381955) |const char| pointer fields are not supported yet.
+ // TODO(crbug.com/40245402) |const char| pointer fields are not supported yet.
//
// No rewrite expected (for now).
const char* const_char_ptr;
