commit d3e1d5190cdf9a5b19d2e981a2a89304ba1ca1fa
author Matt Mueller <mattm@chromium.org> Thu Dec 07 00:23:34 2017
committer Commit Bot <commit-bot@chromium.org> Thu Dec 07 00:23:34 2017
tree 8f9ca76ef9747f0b9d8068ccc95699081f7f413f
parent 4728f7c1c150aa2079f40e157b6ca61783af317d

Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership.

Also renames / removes some X509Certificate methods to make more sense
in the use_byte_certs world:

os_cert_handle() -> cert_buffer()
GetIntermediateCertificates() -> intermediate_buffers()
CreateFromHandle() -> CreateFromBuffer()
CreateOSCertHandleFromBytes() -> CreateCertBufferFromBytes()
CreateOSCertHandlesFromBytes() -> CreateCertBuffersFromBytes()
GetDEREncoded() -> x509_util::CryptoBufferAsStringPiece()
IsSameOSCert() -> x509_util::CryptoBufferEqual()
DupOSCertHandle() -> x509_util::DupCryptoBuffer()
FreeOSCertHandle() -> N/A (everything uses bssl::UniquePtr<CRYPTO_BUFFER>)

Bug: 769549
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5d94158ea5e7ba5e9e3b9f2f5e76221564c9683b
Reviewed-on: https://chromium-review.googlesource.com/775540
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522269}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4193270b51780e7f1146766cfcc232ea2a971fe

ssl/cmpcert.cc

diff --git a/ssl/cmpcert.cc b/ssl/cmpcert.cc
index 64e4828..27ceeb8 100644
--- a/ssl/cmpcert.cc
+++ b/ssl/cmpcert.cc
@@ -35,8 +35,8 @@
   der::Input tbs_certificate_tlv;
   der::Input signature_algorithm_tlv;
   der::BitString signature_value;
-  if (!ParseCertificate(der::Input(CRYPTO_BUFFER_data(cert->os_cert_handle()),
-                                   CRYPTO_BUFFER_len(cert->os_cert_handle())),
+  if (!ParseCertificate(der::Input(CRYPTO_BUFFER_data(cert->cert_buffer()),
+                                   CRYPTO_BUFFER_len(cert->cert_buffer())),
                         &tbs_certificate_tlv, &signature_algorithm_tlv,
                         &signature_value, nullptr)) {
     return false;