commit 4b412995f77df3dab95eab77c8c08ad816dbf776
author Abhijeet Kandalkar <abhijeet@igalia.com> Wed Sep 11 11:19:32 2019
committer Commit Bot <commit-bot@chromium.org> Wed Sep 11 11:19:32 2019
tree 41244f8ea1efbe2ee290bf9040e1be290ff459a2
parent 87a54bf6c18de0f3ded579acd4f05cd978a0f51e

Use new downcast helper for blink::HTMLMeterElement

This CL has two goals,
1. Use DynamicTo<HTMLMeterElement> as new downcast helper
2. Use IsA<HTMLMeterElement>(element) in place of
   IsHTMLMeterElement(element)

Bug: 891908
Change-Id: Ibd4d7866992b0ead69045e10af68d5faa4f36d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794365
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Original-Commit-Position: refs/heads/master@{#695566}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b416cca1c7ba2d451c74016dbdcb69c660eb7f15

blink/renderer/core/css/resolver/style_adjuster.cc

diff --git a/blink/renderer/core/css/resolver/style_adjuster.cc b/blink/renderer/core/css/resolver/style_adjuster.cc
index 98a8b47..552f495 100644
--- a/blink/renderer/core/css/resolver/style_adjuster.cc
+++ b/blink/renderer/core/css/resolver/style_adjuster.cc
@@ -305,7 +305,7 @@
     // See https://drafts.csswg.org/css-display/#unbox-html
     // Some of these elements are handled with other adjustments above.
     if (IsA<HTMLBRElement>(element) || IsHTMLWBRElement(element) ||
-        IsHTMLMeterElement(element) || IsHTMLProgressElement(element) ||
+        IsA<HTMLMeterElement>(element) || IsHTMLProgressElement(element) ||
         IsA<HTMLCanvasElement>(element) || IsHTMLMediaElement(element) ||
         IsHTMLInputElement(element) || IsHTMLTextAreaElement(element) ||
         IsHTMLSelectElement(element)) {

blink/renderer/core/editing/finder/find_buffer.cc

diff --git a/blink/renderer/core/editing/finder/find_buffer.cc b/blink/renderer/core/editing/finder/find_buffer.cc
index 8ef026b..a96e206 100644
--- a/blink/renderer/core/editing/finder/find_buffer.cc
+++ b/blink/renderer/core/editing/finder/find_buffer.cc
@@ -103,7 +103,7 @@
     return false;
   return (!element->ShouldSerializeEndTag() && !IsHTMLInputElement(*element)) ||
          IsA<HTMLIFrameElement>(*element) || IsHTMLImageElement(*element) ||
-         IsA<HTMLLegendElement>(*element) || IsHTMLMeterElement(*element) ||
+         IsA<HTMLLegendElement>(*element) || IsA<HTMLMeterElement>(*element) ||
          IsHTMLObjectElement(*element) || IsHTMLProgressElement(*element) ||
          (IsHTMLSelectElement(*element) &&
           ToHTMLSelectElement(*element).UsesMenuList()) ||

blink/renderer/core/editing/iterators/text_iterator.cc

diff --git a/blink/renderer/core/editing/iterators/text_iterator.cc b/blink/renderer/core/editing/iterators/text_iterator.cc
index d25e2ef..3e49eb0d 100644
--- a/blink/renderer/core/editing/iterators/text_iterator.cc
+++ b/blink/renderer/core/editing/iterators/text_iterator.cc
@@ -378,7 +378,7 @@
                        (IsHTMLFormControlElement(html_element) ||
                         IsA<HTMLLegendElement>(html_element) ||
                         IsHTMLImageElement(html_element) ||
-                        IsHTMLMeterElement(html_element) ||
+                        IsA<HTMLMeterElement>(html_element) ||
                         IsHTMLProgressElement(html_element))))) {
             HandleReplacedElement();
           } else {

blink/renderer/modules/accessibility/ax_node_object.cc

diff --git a/blink/renderer/modules/accessibility/ax_node_object.cc b/blink/renderer/modules/accessibility/ax_node_object.cc
index eace996..3e59985 100644
--- a/blink/renderer/modules/accessibility/ax_node_object.cc
+++ b/blink/renderer/modules/accessibility/ax_node_object.cc
@@ -598,7 +598,7 @@
   if (IsHTMLDivElement(*GetNode()))
     return ax::mojom::Role::kGenericContainer;
 
-  if (IsHTMLMeterElement(*GetNode()))
+  if (IsA<HTMLMeterElement>(*GetNode()))
     return ax::mojom::Role::kMeter;
 
   if (IsHTMLProgressElement(*GetNode()))
@@ -1723,7 +1723,7 @@
     return std::isfinite(*out_value);
   }
 
-  if (auto* meter = ToHTMLMeterElementOrNull(GetNode())) {
+  if (auto* meter = DynamicTo<HTMLMeterElement>(GetNode())) {
     *out_value = meter->value();
     return true;
   }
@@ -1769,7 +1769,7 @@
     return std::isfinite(*out_value);
   }
 
-  if (auto* meter = ToHTMLMeterElementOrNull(GetNode())) {
+  if (auto* meter = DynamicTo<HTMLMeterElement>(GetNode())) {
     *out_value = meter->max();
     return true;
   }
@@ -1802,7 +1802,7 @@
     return std::isfinite(*out_value);
   }
 
-  if (auto* meter = ToHTMLMeterElementOrNull(GetNode())) {
+  if (auto* meter = DynamicTo<HTMLMeterElement>(GetNode())) {
     *out_value = meter->min();
     return true;
   }