commit 6d2d065d9ee0f11ed919a07caa0041a1b8d54e8b
author Nasko Oskov <nasko@chromium.org> Sat Dec 15 00:24:55 2018
committer Commit Bot <commit-bot@chromium.org> Sat Dec 15 00:24:55 2018
tree eee0a733fe3f42b7cbd52a807af41eb5fb7530b3
parent 692c45c3a8b7855addf13bc9663088839aef16e7

FrameLoadRequest should reuse origin instead of recreating it.

FrameLoadRequest is currently constructing the requestor origin from
the URL of the requestor document. However, constructing origins based
on URL is a lossy process and does not preserve precursor origin
information.
Since the requestor document is already passed in as a parameter, the
origin of the document should be used directly. This CL changes that.

It also fixes a bug in the GetDownloadPolicy method where origin
comparison is assigned to a boolean incorrectly.

Bug: 632514, 882053
Change-Id: Ibb386ef7ecddc0b5dcc5b9e2b83f7b5215fdc1e9
Reviewed-on: https://chromium-review.googlesource.com/c/1378587
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6e845755633a4fd21c5a2492cc9b587f0248f7f3

blink/renderer/core/loader/frame_load_request.cc

diff --git a/blink/renderer/core/loader/frame_load_request.cc b/blink/renderer/core/loader/frame_load_request.cc
index fa6fdde..4759315 100644
--- a/blink/renderer/core/loader/frame_load_request.cc
+++ b/blink/renderer/core/loader/frame_load_request.cc
@@ -51,8 +51,7 @@
 
   if (origin_document) {
     DCHECK(!resource_request_.RequestorOrigin());
-    resource_request_.SetRequestorOrigin(
-        SecurityOrigin::Create(origin_document->Url()));
+    resource_request_.SetRequestorOrigin(origin_document->GetSecurityOrigin());
 
     if (resource_request.Url().ProtocolIs("blob") &&
         BlobUtils::MojoBlobURLsEnabled()) {