Refactor inspector protocol compiles.
This removes the duplication of outputs from core/inspector:protocol_sources to
the compiled version in core:core_generated. A new target is created
core/inspector:protocol that uses get_target_outputs on :protocol_sources to
avoid duplicating the sources list.
To make this easier to implement, the core_config_add and core_config_remove
configs list were moved to core.gni so it can be shared with multiple core
build files.
The inspector_protocol.gni file was changed from listing the sources to
defining a template to run the script. This elimiates some duplicated code
between the two users of this script.
BUG=
Review-Url: https://codereview.chromium.org/2294123002
Cr-Original-Commit-Position: refs/heads/master@{#415777}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd219210ff98b771af6a9ed93852dcf8e242a442
diff --git a/inspector_protocol.gni b/inspector_protocol.gni
index 324062e..4b161a0 100644
--- a/inspector_protocol.gni
+++ b/inspector_protocol.gni
@@ -2,31 +2,81 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-inspector_protocol_sources =
- get_path_info([
- "lib/Allocator_h.template",
- "lib/Array_h.template",
- "lib/BackendCallback_h.template",
- "lib/Collections_h.template",
- "lib/DispatcherBase_cpp.template",
- "lib/DispatcherBase_h.template",
- "lib/ErrorSupport_cpp.template",
- "lib/ErrorSupport_h.template",
- "lib/Forward_h.template",
- "lib/FrontendChannel_h.template",
- "lib/Maybe_h.template",
- "lib/Object_cpp.template",
- "lib/Object_h.template",
- "lib/Parser_cpp.template",
- "lib/Parser_h.template",
- "lib/Protocol_cpp.template",
- "lib/ValueConversions_h.template",
- "lib/Values_cpp.template",
- "lib/Values_h.template",
- "templates/Exported_h.template",
- "templates/Imported_h.template",
- "templates/TypeBuilder_cpp.template",
- "templates/TypeBuilder_h.template",
- "CodeGenerator.py",
- ],
- "abspath")
+# This template will generate inspector protocol source code. The code will
+# not be compiled, use get_target_outputs(<name>) to compile them.
+#
+# Inputs
+#
+# config_file (required)
+# Path to json file specifying inspector protocol configuration.
+#
+# out_dir (required)
+# Path to put the generated files in. It must be inside output or
+# generated file directory.
+#
+# outputs (required)
+# Files generated. Relative to out_dir.
+#
+# inputs (optional)
+# Extra inputs specified by the config file.
+template("inspector_protocol_generate") {
+ assert(defined(invoker.config_file))
+ assert(defined(invoker.out_dir))
+ assert(defined(invoker.outputs))
+
+ inspector_protocol_dir =
+ "//third_party/WebKit/Source/platform/inspector_protocol"
+
+ action(target_name) {
+ script = "$inspector_protocol_dir/CodeGenerator.py"
+
+ inputs = [
+ invoker.config_file,
+ "$inspector_protocol_dir/lib/Allocator_h.template",
+ "$inspector_protocol_dir/lib/Array_h.template",
+ "$inspector_protocol_dir/lib/BackendCallback_h.template",
+ "$inspector_protocol_dir/lib/Collections_h.template",
+ "$inspector_protocol_dir/lib/DispatcherBase_cpp.template",
+ "$inspector_protocol_dir/lib/DispatcherBase_h.template",
+ "$inspector_protocol_dir/lib/ErrorSupport_cpp.template",
+ "$inspector_protocol_dir/lib/ErrorSupport_h.template",
+ "$inspector_protocol_dir/lib/Forward_h.template",
+ "$inspector_protocol_dir/lib/FrontendChannel_h.template",
+ "$inspector_protocol_dir/lib/Maybe_h.template",
+ "$inspector_protocol_dir/lib/Object_cpp.template",
+ "$inspector_protocol_dir/lib/Object_h.template",
+ "$inspector_protocol_dir/lib/Parser_cpp.template",
+ "$inspector_protocol_dir/lib/Parser_h.template",
+ "$inspector_protocol_dir/lib/Protocol_cpp.template",
+ "$inspector_protocol_dir/lib/ValueConversions_h.template",
+ "$inspector_protocol_dir/lib/Values_cpp.template",
+ "$inspector_protocol_dir/lib/Values_h.template",
+ "$inspector_protocol_dir/templates/Exported_h.template",
+ "$inspector_protocol_dir/templates/Imported_h.template",
+ "$inspector_protocol_dir/templates/TypeBuilder_cpp.template",
+ "$inspector_protocol_dir/templates/TypeBuilder_h.template",
+ ]
+ if (defined(invoker.inputs)) {
+ inputs += invoker.inputs
+ }
+
+ args = [
+ "--jinja_dir",
+ rebase_path("//third_party/", root_build_dir), # jinja is in chromium's third_party
+ "--output_base",
+ rebase_path(invoker.out_dir, root_build_dir),
+ "--config",
+ rebase_path(invoker.config_file, root_build_dir),
+ ]
+
+ outputs = get_path_info(rebase_path(invoker.outputs, ".", invoker.out_dir),
+ "abspath")
+
+ forward_variables_from(invoker,
+ [
+ "visibility",
+ "deps",
+ "public_deps",
+ ])
+ }
+}
