win: Unconditionally download clang during runhooks
This adds an additional ~50MB download to runhooks every few weeks.
The motivation for doing this is two-fold:
1. It makes it easier for people to try out clang on Windows
2. libyuv currently uses relatively unoptimized C-only functions
on 64-bit Windows due to cl not supporting inline assembly.
clang-cl does, and building libyuv with clang-cl speeds up
some libyuv conversion functions to take 0.4ms instead of 2ms
per frame, so we want to try and build just libyuv with clang
even in MSVC builds.
BUG=692600,82385
Review-Url: https://codereview.chromium.org/2702113005
Cr-Original-Commit-Position: refs/heads/master@{#451827}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 43c2826bfce0d245221aab0183a0e9f3f883a7f4
diff --git a/scripts/update.py b/scripts/update.py
index dc7a439..5fa6812 100755
--- a/scripts/update.py
+++ b/scripts/update.py
@@ -862,20 +862,7 @@
args.lto_gold_plugin = False
if args.if_needed:
- is_clang_required = False
- # clang is always used on Mac and Linux.
- if sys.platform == 'darwin' or sys.platform.startswith('linux'):
- is_clang_required = True
- # clang requested via $GYP_DEFINES.
- if re.search(r'\b(clang|asan|lsan|msan|tsan)=1',
- os.environ.get('GYP_DEFINES', '')):
- is_clang_required = True
- # clang previously downloaded, keep it up to date.
- # If you don't want this, delete third_party/llvm-build on your machine.
- if os.path.isdir(LLVM_BUILD_DIR):
- is_clang_required = True
- if not is_clang_required:
- return 0
+ # TODO(thakis): Can probably remove this and --if-needed altogether.
if re.search(r'\b(make_clang_dir)=', os.environ.get('GYP_DEFINES', '')):
print 'Skipping Clang update (make_clang_dir= was set in GYP_DEFINES).'
return 0
