commit | 4c6074c043634580f7c571cd7c280c47641db1bc | [log] [tgz] |
---|---|---|
author | Joey Scarr <jsca@google.com> | Thu Jun 07 00:23:51 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jun 07 00:23:51 2018 |
tree | 30398206643b915c08c44b51135337c78e2ee2c5 | |
parent | 8a9d3b43c6139026d8a572ebccfe7cdb3121fb2f [diff] |
Fix quoting when writing defines on Windows. For the following string-valued define: defines = [ "CR_CLANG_REVISION=\"$clang_revision\"" ] this was outputting the following on Windows: -D"CR_CLANG_REVISION=\"332838-1\"" The Windows shell can't handle the extra quotes, and so the following macro was being written: #define "CR_CLANG_REVISION "332838-1"" This change moves the first quote to before the -D, allowing Windows to correctly handle the define parameter. R=brettw@chromium.org Bug: 396230 Change-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1 Reviewed-on: https://chromium-review.googlesource.com/1071274 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#565117} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 44054a1e89063bf0063cfc4d72632c2f1589ee8b
GN is a meta-build system that generates Ninja build files so that you can build Chromium with Ninja.
Read these links: